Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amount field #7

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Add amount field #7

merged 4 commits into from
Apr 8, 2024

Conversation

mkalinin
Copy link
Contributor

@mkalinin mkalinin commented Apr 4, 2024

Adds an amount field by appending it to the end of the calldata, right after the pubkey.

input calldata
+--------+--------+
| pubkey | amount |
+--------+--------+
    48       8

storage
+------+--------------+-------------------------+
| addr | pubkey[0:32] | pubkey[32:48] ++ amount |
+------+--------------+-------------------------+

output memory record
+------+--------+--------+
| addr | pubkey | amount |
+------+--------+--------+
   20      48       8

Depends on #6

Copy link
Owner

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I made a few small style tweaks and updated the tests.

@lightclient lightclient merged commit 58aa905 into lightclient:main Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants