fix: headless browser tag #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rephus
approved these changes
Jan 2, 2025
| @@ -54,7 +54,7 @@ If you don't want helm to manage this, you may wish to separately create a secre | |||
| | backendConfig.create | bool | `false` | | | |||
| | browserless-chrome.enabled | bool | `true` | | | |||
| | browserless-chrome.env.CONNECTION_TIMEOUT | string | `"180000"` | | | |||
| | browserless-chrome.image.tag | string | `""` | | | |||
| | browserless-chrome.image.tag | string | `"1.61.1-chrome-stable"` | | | |||
There was a problem hiding this comment.
I'm surprised this latest version is 1 year old...
anyhow, I tested this version locally and it is working as expected
|
Don't we need to bump the helm chart version for this ? |
Yes. bumped version ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: lightdash/lightdash#13059
The empty image.tag value was making the browserless chrome image default to 1.48 which is the browserless-chrome chart appVersion, that is 3 years old
This caused some self-hosted users to have blank images in their scheduled deliveries.