Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Out of bounds node remain on screen after going out of view port #379

Closed
wouterlucas opened this issue Sep 13, 2024 · 0 comments · Fixed by #380
Closed

Out of bounds node remain on screen after going out of view port #379

wouterlucas opened this issue Sep 13, 2024 · 0 comments · Fixed by #380
Assignees
@wouterlucas

Comments

@wouterlucas
Copy link
Contributor

The out of bounds marking of a "dead" section of the tree is too eager, if nodes transition from InView port to OutOfBounds they need to finish their entire update loop first before being marked as "dead".

E.g. when you navigate from a list from the end to the start you end up with this:
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wouterlucas wouterlucas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Move marking the outOfBound render state to the end of the updat… lightning-js/renderer
1 participant
@wouterlucas