Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Move marking the outOfBound render state to the end of the updat… #380

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix: Move marking the outOfBound render state to the end of the updat… #380

merged 1 commit into from
Sep 13, 2024

Conversation

wouterlucas
Copy link
Contributor

…e loop

@wouterlucas wouterlucas linked an issue Sep 13, 2024 that may be closed by this pull request
Out of bounds node remain on screen after going out of view port #379
Closed
michielvandergeest
michielvandergeest approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@michielvandergeest michielvandergeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wouterlucas wouterlucas added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 7d59fa4 Sep 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michielvandergeest michielvandergeest michielvandergeest approved these changes

@erikhaandrikman erikhaandrikman Awaiting requested review from erikhaandrikman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Out of bounds node remain on screen after going out of view port
2 participants
@wouterlucas @michielvandergeest