Fix simple scene rendering #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple scenes that do not involve textures, text or any later mutations were not rendering to the canvas. This is due to the default texture "ColorTexture" not being loaded prior to the scene being rendered. This texture must be loaded before any solid color Nodes will render. When this issue was happening the RAF was paused right before the texture was loaded and that texture loaded event did not trigger a requestRender() from the stage. The solution here is to request a render once from the stage after the default texture has loaded.
frank-weindel
requested review from
wouterlucas,
chiefcll,
michielvandergeest and
erikhaandrikman
chiefcll
approved these changes
Jan 29, 2024
erikhaandrikman
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple scenes that do not involve textures, text or any later mutations were not rendering to the canvas. This is due to the default texture "ColorTexture" not being loaded prior to the scene being rendered. This texture must be loaded before any solid color Nodes will render. When this issue was happening the RAF was paused right before the texture was loaded and that texture loaded event did not trigger a requestRender() from the stage.
The solution here is to request a render once from the stage after the default texture has loaded.
Fixes #123