Texture Compression #143
Merged
Texture Compression #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -33,7 +33,10 @@ sdfData.chars.forEach((glyph) => { | |||
| describe('measureText', () => { | |||
| it('should measure text width', () => { | |||
| const PERIOD_WIDTH = 10.332; | |||
| const shaper = new SdfFontShaper(sdfData as unknown as SdfFontData, glyphMap); | |||
| const shaper = new SdfFontShaper( | |||
There was a problem hiding this comment.
Any reason these lines got touched with formatting?
There was a problem hiding this comment.
Not really sure, using the project configured formatter
examples/tests/tx-compression.ts
Outdated
| import type { ExampleSettings } from '../common/ExampleSettings.js'; | ||
|
|
||
| export async function automation(settings: ExampleSettings) { | ||
| await test(settings); |
There was a problem hiding this comment.
Did you forget to commit the certified snapshot for this test?
There was a problem hiding this comment.
I have removed visual regression testing from the compression test due to the apparent lack of support for compressed textures in Playwright.
|
Looks great to me! Just had mostly minor suggestions. |
frank-weindel
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces initial support for .KTX and .PVR contained compressed textures. The format will be internally indicated.