Renderer v1.0.0 #325
Merged
Renderer v1.0.0 #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove CoreExtension concept
Hopefully...
ThreadX is a feature implemented to support offscreen canvas multithreading, however browser support for ThreadX will not come soon to our space (TV / STB market) and the current implementation has some negative side effects. With the introduction of Drivers there is a lot of double housekeeping, maintaining two tree's of nodes, the `DriverNode` and `CoreNode`. This causes additional processing overhead (mainly extra function invocations and emitters) and an additional list of nodes stored in memory. In the future we should ensure all ThreadX specifics are retained in the ThreadX module, likely by providing a RendererMain replacement from the ThreadX project and proxy the CoreNode respectively as we communicate over threads. And keep the specifics to ThreadX to where they belong. Early test results: current master: 20k nodes create 2867ms @ 65 MB HEAP:   this pr: 20k nodes create 1272ms @ 35 MB HEAP:   About 2.2x faster and nearly 50% less memory on an excessive stress test. Todo: - [x] Fix RTT - [ ] Fix/review VRT test results - [ ] Run an app on it
- NoiseTexture: If cacheId not provided, don't cache the texture
Also - NoiseTexture: If cacheId not provided, don't cache the texture Fixes issue with the `threshold-texture-memory` test
Noticed this and wanted to fix it real quick
Slightly changed the checkRenderBounds function, and simplified the emitting process according to the changes Frank made for PR #231
This refactor eliminates the ctxTextureCache WeakMap and replaces it with access to CoreContextTextures directly from Texture objects themselves. Since access is more direct and does not require a map look up each time this change should be performance positive. It also simplifies the code a good bit. This is being done as a foundational step for further Texture memory work.
This refactor eliminates the ctxTextureCache WeakMap and replaces it with access to CoreContextTextures directly from Texture objects themselves. Since access is more direct and does not require a map look up each time this change should be performance positive. It also simplifies the code a good bit. This is being done as a foundational step for further Texture memory work.
We are using the same calculations for the renderCoords we use in the .addQuad function in the WebGLCoreRenderer, with this fix we can use the already calculated renderCoords without having to do the calculations again every time a draw call is made.
Following the CSS3 spec https://drafts.csswg.org/css-backgrounds-3/#corner-overlap Signed-off-by: M4tiz <[email protected]>
Prior to this change, the VRT Dockerfile installed the latest version of PNPM instead of that is specified in the project's package.json (8.9.2 as of this writing). This led to an issue where everytime you ran the VRT tests in --ci mode it would run pnpm 9 which would incorrectly update the pnpm-lock.yaml file. This change uses `corepack` to install the project's version of PNPM.
- Add an example project that shows how to create/install custom shaders/effects/textures - Update README.md to show how to install fonts post core extensions
Prior to this change, the VRT Dockerfile installed the latest version of PNPM instead of that is specified in the project's package.json (8.9.2 as of this writing). This led to an issue where everytime you ran the VRT tests in --ci mode it would run pnpm 9 which would incorrectly update the pnpm-lock.yaml file. This change uses `corepack` to install the project's version of PNPM.
- Add an example project that shows how to create/install custom shaders/effects/textures - Update README.md to show how to install fonts post core extensions
Add quadBuffer usage log
Fixes missing function name in image worker blob when building with vite
TextureTypeMap was introduced when ThreadX was removed, and TextureMap existed as the "instance" version of TextureTypeMap. This is inconsistent with the ShaderMap and EffectMap, which don't have "instance" versions. To fix this inconsistency, the "instance" version is removed and TextureTypeMap is renamed back to TextureMap
TextureTypeMap was introduced when ThreadX was removed, and TextureMap existed as the "instance" version of TextureTypeMap. This is inconsistent with the ShaderMap and EffectMap, which don't have "instance" versions. To fix this inconsistency, the "instance" version is removed and TextureTypeMap is renamed back to TextureMap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See