Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boundary detection fixes #377

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Boundary detection fixes #377

merged 2 commits into from
Sep 12, 2024

Conversation

wouterlucas
Copy link
Contributor

Fixes #371 and various other parent/child updates with Bounds detection.

Changes:

  • children update state, whenever the branch becomes active again they will be propagated accordingly
  • Alpha and clipping now properly trigger children updates when active again
  • Larger then bound detection, for full width child nodes (one of the clipping VRT tests)
  • Ability to handle dimension-less "holder" nodes with boundary checks
  • Small child iteration loop optimizations

Small sacrifices on performance as more parts of the tree will remain active (though still 125 -> 650k ops/s) , the original 2.1.0 release was a bit too aggressive marking part of the render tree "dead" due to not being able to handle "holder" nodes who do not have dimensions and once marked inactive would discard children updates.

@wouterlucas wouterlucas added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit 0456b0c Sep 12, 2024
2 checks passed
@wouterlucas wouterlucas deleted the fix/bounds_children branch September 12, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clipping is "delayed" in renderer 2.1 release
2 participants