fix: re-evaluate isRenderable on alpha change #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On low powered devices / heavy operation UI's there might be a race condition where the animation/transition is ends prior to the update loop finishing its first run. This causes the isRenderable to not be evaluated in time for the alpha changes to take affect.
This PR ensures isRenderable is always re-evaluated on an alpha change and moves the worldAlpha calculation slightly up to ensure it gets handled in the correct order if its a 1 shot update.
Also save a little processing by ensuring on alpha change the children only re-evaluate the worldAlpha and not a global, reducing child update processing.
Fixes #388
Might fix #372 - though cant reproduce to validate on my setup (even with 20x slowdown).