Implement Visual Regression Tests / Runner #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including GitHub Action
frank-weindel
requested review from
wouterlucas,
chiefcll,
Drulokia,
jfboeve,
michielvandergeest,
erikhaandrikman and
uguraslan
wouterlucas
reviewed
Nov 29, 2023
wouterlucas
requested changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See new / updated READMEs for details on how to run / define / capture snapshots.
I would've used WebKit for the browser, since its the closest to WPE, but I'm unable to get Playwright to work with WebKit at this time. I think for the sake of visual regression (vs actually verifying that a specific browser is rendering correctly) this is fine.
New in this PR
This now includes a Docker CI mode with the
--ciargument a GitHub Action which runs VRT and Unit Tests on all PRs.