Fix shaders not rendering overworld stars properly #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where stars would render in the day as black dots while using certain shaders:
Complementary Shaders Reimagined (With Embeddium & Oculus), Current Northstar Version:
This PR fixes this bug by rendering stars in the same area of code where vanilla stars are rendered (So the stars are rendered are in the same stage as vanilla stars, which makes shaders treat them like vanilla stars), I removed unused code from the
renderSky2mixin and renamed it torenderSkyStarsOverworld.I also reformatted the entire
LevelRendererMixin.javafile, which unfortunately makes this PR very hard to review. (sorry about that, you can enable "Hide Widespace" in the options to make it easier)Also flying above Y450 still looks like it did before (with black stars and no earth below), I might fix that in a later PR.