Cut 0.0.124.0 #165
Merged
Cut 0.0.124.0 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we clone an object before passing to/from native code, we generally don't need to hold a reference to that object in the struct that owns the method. The one exception we include here is if the object being passed is either a trait or holds a reference to a trait. Its not clear if this is required but it seems like a potential sharp edge.
|
Determinism passed at https://github.com/TheBlueMatt/ldk-garbagecollected/actions/runs/10720959128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to upstream LDK 0.0.124 changes, this also reduces references which may reduce the chance of memory leaks.