Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to bitcoinj-0.17-beta1, fix some deprecations #167

Merged

Conversation

msgilligan
Copy link
Contributor

This is a drive-by contribution and I was unable to test locally, so I will mark it as DRAFT.

I also made a couple IDE warnings go away.

This is a drive-by contribution and I was unable to test locally, so I
will mark it as DRAFT.

I also made a couple IDE warnings go away.
@msgilligan
Copy link
Contributor Author

msgilligan commented Sep 5, 2024

It looks like the java_bindings job ran successfully, so maybe I got lucky and didn't break anything. So I guess I'll mark it as ready-for-review.

@msgilligan msgilligan marked this pull request as ready for review September 5, 2024 23:00
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks.

@TheBlueMatt TheBlueMatt merged commit 381e97e into lightningdevkit:main Oct 14, 2024
3 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants