Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use KeyObfuscator in VssStore. #378

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Use KeyObfuscator in VssStore. #378

merged 1 commit into from
Oct 17, 2024

Conversation

G8XSU
Copy link
Contributor

@G8XSU G8XSU commented Oct 15, 2024

Based #369

@G8XSU G8XSU requested a review from tnull October 15, 2024 22:38
tnull
tnull reviewed Oct 16, 2024
View reviewed changes
src/io/vss_store.rs Outdated Show resolved Hide resolved
@G8XSU G8XSU requested a review from tnull October 17, 2024 00:16
tnull
tnull reviewed Oct 17, 2024
View reviewed changes
src/io/vss_store.rs Outdated Show resolved Hide resolved
src/io/vss_store.rs Outdated Show resolved Hide resolved
src/io/vss_store.rs Outdated Show resolved Hide resolved
src/io/vss_store.rs Outdated Show resolved Hide resolved
@tnull
Copy link
Collaborator

tnull commented Oct 17, 2024

Needs a rebase now that #369 landed.

@G8XSU
Copy link
Contributor Author

G8XSU commented Oct 17, 2024

Rebased

@G8XSU G8XSU requested a review from tnull October 17, 2024 08:45
tnull
tnull reviewed Oct 17, 2024
View reviewed changes
src/io/vss_store.rs Outdated Show resolved Hide resolved
@G8XSU G8XSU requested a review from tnull October 17, 2024 09:00
tnull
tnull reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to squash.

I added one comment to simplify the derivation a bit (and save the concat), but you're choice whether to address it while squashing (as it doesn't change anything material).

src/io/vss_store.rs Show resolved Hide resolved
@G8XSU
Use KeyObfuscator in VssStore.
0ae0fc1 
For client-side key obfuscation, improving privacy and security.
@G8XSU
Copy link
Contributor Author

G8XSU commented Oct 17, 2024

Squashed fixups.

@tnull tnull merged commit 5909063 into lightningdevkit:main Oct 17, 2024
8 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnull tnull tnull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@G8XSU @tnull