Skip to content

Adapt to new pay_for_offer call #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2025
Merged

Adapt to new pay_for_offer call #639

merged 1 commit into from
Sep 22, 2025

Conversation

joostjager
Copy link
Contributor

@joostjager joostjager commented Sep 18, 2025 •
edited
Loading

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Sep 18, 2025 •
edited
Loading

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@joostjager joostjager mentioned this pull request Sep 18, 2025
Merged
@joostjager joostjager requested a review from tnull September 18, 2025 18:36
tnull
tnull reviewed Sep 19, 2025
View reviewed changes
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please provide a commit message.

@TheBlueMatt TheBlueMatt mentioned this pull request Sep 20, 2025
Open
@joostjager
Adapt to new pay_for_offer call in upstream LDK
97f404f 
Updated `pay_for_offer` call with `OptionalOfferPaymentParams`
and delegate to `pay_for_offer_with_quantity` when needed.
@joostjager joostjager force-pushed the pay-for-offer-refactor branch from d6e60f7 to 97f404f Compare September 22, 2025 08:53
@joostjager joostjager requested a review from tnull September 22, 2025 08:53
tnull
tnull approved these changes Sep 22, 2025
View reviewed changes
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@tnull tnull merged commit 569e910 into lightningdevkit:develop Sep 22, 2025
5 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnull tnull tnull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joostjager @ldk-reviews-bot @tnull