Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to LDK 0.0.116 #107

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Jul 7, 2023

No description provided.

@tnull tnull marked this pull request as draft July 7, 2023 13:47
@tnull tnull force-pushed the 2023-07-upgrade-to-0.0.116 branch from b84d8b8 to 364d47d Compare July 7, 2023 13:53
@tnull tnull force-pushed the 2023-07-upgrade-to-0.0.116 branch 4 times, most recently from cf261c6 to 7dfaed5 Compare July 10, 2023 08:10
@TheBlueMatt
Copy link
Contributor

Care to update to v0.0.116-rc1? Or, by the time you get to it, hopefully final.

@tnull tnull force-pushed the 2023-07-upgrade-to-0.0.116 branch 2 times, most recently from 83cd7fb to 7069455 Compare July 21, 2023 07:49
@tnull
Copy link
Contributor Author

tnull commented Jul 21, 2023

Care to update to v0.0.116-rc1? Or, by the time you get to it, hopefully final.

Sure, updated to v0.0.116-rc1!

@tnull tnull force-pushed the 2023-07-upgrade-to-0.0.116 branch 2 times, most recently from 0d9e2c3 to b07b101 Compare July 24, 2023 07:17
@tnull tnull marked this pull request as ready for review July 24, 2023 07:17
@tnull
Copy link
Contributor Author

tnull commented Jul 24, 2023

Switched to the 0.0.116 dependency after release. Let me know if I can squash.

@dunxen
Copy link

dunxen commented Jul 24, 2023

Looks good for squash

Copy link
Contributor

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to squash.

Cargo.lock Outdated Show resolved Hide resolved
src/bitcoind_client.rs Show resolved Hide resolved
src/convert.rs Outdated Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
@tnull tnull force-pushed the 2023-07-upgrade-to-0.0.116 branch from b07b101 to 10f32f7 Compare July 25, 2023 07:04
@tnull
Copy link
Contributor Author

tnull commented Jul 25, 2023

Squashed commits and included the following changes:

> git diff-tree -U2  b07b101 10f32f7
diff --git a/Cargo.lock b/Cargo.lock
index 0744d35..cb154ee 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -258,7 +258,7 @@ checksum = "201de327520df007757c1f0adce6e827fe8562fbc28bfd9c15571c66ca1f5f79"
 [[package]]
 name = "lightning"
-version = "0.0.116-rc1"
+version = "0.0.116"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "50c6c84735c5cc242a9e539a6b7c03090c2873c3f133d154e44935768cadb99c"
+checksum = "90a0f2155316f1570446a0447c993480673f840748c8ed25bbc59dfc442ac770"
 dependencies = [
  "bitcoin",
@@ -267,7 +267,7 @@ dependencies = [
 [[package]]
 name = "lightning-background-processor"
-version = "0.0.116-rc1"
+version = "0.0.116"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "3b14ece9b451868dcac597cfced5775abdb17645aa85560c364d10483e2bbc43"
+checksum = "398b68a96cceb3c1227504bd5faeb74f26c3233447bc10cc1cb2c67e01b51556"
 dependencies = [
  "bitcoin",
@@ -278,7 +278,7 @@ dependencies = [
 [[package]]
 name = "lightning-block-sync"
-version = "0.0.116-rc1"
+version = "0.0.116"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "a21aeb31b4401711ccc6d61a15ded3793dff1325811be73e9abd3803f113155e"
+checksum = "d94c276dbe2a777d58ed6ececca96006247a4717c00ac4cdfff62d76852be783"
 dependencies = [
  "bitcoin",
@@ -290,7 +290,7 @@ dependencies = [
 [[package]]
 name = "lightning-invoice"
-version = "0.24.0-rc1"
+version = "0.24.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "8fa47c082863fb8a5a514e8d0beaf4bec516bd031422f062306705f5658e1bb6"
+checksum = "1788c0158526ec27a502043c2911ea6ea58fdc656bdf8749484942c07b790d23"
 dependencies = [
  "bech32 0.9.1",
@@ -304,7 +304,7 @@ dependencies = [
 [[package]]
 name = "lightning-net-tokio"
-version = "0.0.116-rc1"
+version = "0.0.116"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "1864f332e0985b1a9ee783023d83893adced63f1b0dc7703cd46819135550685"
+checksum = "366c0ae225736cbc03555bd5fb4b44b2e8fe2ca3c868ec53a4b325c38b2ab2bd"
 dependencies = [
  "bitcoin",
@@ -315,7 +315,7 @@ dependencies = [
 [[package]]
 name = "lightning-persister"
-version = "0.0.116-rc1"
+version = "0.0.116"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "b2cd91d0c60c6874d3aac412d8ea632c8361c924aee36bf6af4929a26127ca62"
+checksum = "93caaafeb42115b70119619c2420e362cce776670427fc4ced3e6df77b41c0b6"
 dependencies = [
  "bitcoin",
@@ -327,7 +327,7 @@ dependencies = [
 [[package]]
 name = "lightning-rapid-gossip-sync"
-version = "0.0.116-rc1"
+version = "0.0.116"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "8eeb21da5c9992d4e4bcad2a7f41ca5f7c30b22fd86e115b33f91948f20c21ce"
+checksum = "8a07af5814234924e623bca499e003fca1864024d5bd984e752230f73a131584"
 dependencies = [
  "bitcoin",
diff --git a/src/convert.rs b/src/convert.rs
index 9676a9f..84b033e 100644
--- a/src/convert.rs
+++ b/src/convert.rs
@@ -50,4 +50,5 @@ impl TryInto<NewAddress> for JsonResponse {
        }
 }
+
 pub struct FeeResponse {
        pub feerate_sat_per_kw: Option<u32>,
@@ -83,4 +84,5 @@ impl TryInto<MempoolMinFeeResponse> for JsonResponse {
        fn try_into(self) -> std::io::Result<MempoolMinFeeResponse> {
                let errored = !self.0["errors"].is_null();
+               assert_eq!(self.0["maxmempool"].as_u64(), Some(300000000));
                Ok(MempoolMinFeeResponse {
                        errored,

@TheBlueMatt
Copy link
Contributor

Needs a minor rebase.

@tnull tnull force-pushed the 2023-07-upgrade-to-0.0.116 branch from 10f32f7 to 8098135 Compare July 25, 2023 18:46
@tnull
Copy link
Contributor Author

tnull commented Jul 25, 2023

Needs a minor rebase.

Rebased.

Copy link
Contributor

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheBlueMatt TheBlueMatt merged commit b7daadc into lightningdevkit:main Jul 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants