Use bitcoin core's logic for anti-fee-sniping #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
fee-sniping
branch
2 times, most recently
from
e52e372
to
b448c1a
Compare
tnull
reviewed
Sep 25, 2023
src/sweep.rs
Outdated
| // 10% of the time | ||
| if thread_rng().gen_range(0, 10) == 0 { | ||
| // subtract random number between 0 and 100 | ||
| cur_height -= thread_rng().gen_range(0, 100); |
There was a problem hiding this comment.
Not sure if it's generally worth (after all this is just a sample..), but if we go that way this should be saturated_sub to make sure we're never underflowing.
There was a problem hiding this comment.
Technically should be safe because you can't spend coins until the 101st block.
Can add tho
benthecarman
force-pushed
the
fee-sniping
branch
from
b448c1a
to
f5079a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ldk sample uses core's wallet, would make sense to copy its fee sniping logic