Skip to content

Commit

Permalink
Drop Debug on InMemorySigner (and EntropySource)
Browse files Browse the repository at this point in the history
`InMemorySigner` has various private keys in it which makes
`Debug` either useless or dangerous (because most keys won't log
anything, but if they did we'd risk logging private key material).
  • Loading branch information
TheBlueMatt committed Sep 11, 2024
1 parent d35239c commit 758747a
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions lightning/src/sign/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1027,7 +1027,6 @@ pub trait ChangeDestinationSource {
///
/// This implementation performs no policy checks and is insufficient by itself as
/// a secure external signer.
#[derive(Debug)]
pub struct InMemorySigner {
/// Holder secret key in the 2-of-2 multisig script of a channel. This key also backs the
/// holder's anchor output in a commitment transaction, if one is present.
Expand Down Expand Up @@ -2475,7 +2474,6 @@ impl PhantomKeysManager {
}

/// An implementation of [`EntropySource`] using ChaCha20.
#[derive(Debug)]
pub struct RandomBytes {
/// Seed from which all randomness produced is derived from.
seed: [u8; 32],
Expand Down

0 comments on commit 758747a

Please sign in to comment.