Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to disable broadcasting when it's dangerous due to information loss #1593

Closed
wants to merge 10 commits into from
Closed

Add flag to disable broadcasting when it's dangerous due to information loss #1593

wants to merge 10 commits into from

Commits on Sep 5, 2022

  1. Add flag to disable broadcasting when it's dangerous due to informati… 

    …on loss
    @QPotato
    QPotato committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    9445382 View commit details
    Browse the repository at this point in the history

  2. - Add the new flag on de/serialization 

    - Add a functional test
- Fix some typos I found while reading the code
    @QPotato
    QPotato committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    f7c2023 View commit details
    Browse the repository at this point in the history

  3. remove pub(crate)

    @QPotato
    QPotato committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    dff01e1 View commit details
    Browse the repository at this point in the history

  4. Partially address review 

    - Use `check_closed_event` instead of clearing pending events
- Write new property and read it from TLVs
    @QPotato
    QPotato committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    7342d8c View commit details
    Browse the repository at this point in the history

  5. Use pub on force_broadcast_latest_holder_commitment_txn_unsafe so t… 

    …hat it's exposed to library users and not an unreferenced symbol.
    @QPotato
    QPotato committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    0da0f93 View commit details
    Browse the repository at this point in the history

  6. Remove a reference to toxic holder commitment transaction

    @QPotato
    QPotato committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    f0f8c83 View commit details
    Browse the repository at this point in the history

  7. Remove second reference to toxic holder commitment txn but keeping th… 

    …e info log in the case the txn is already signed.
    @QPotato
    QPotato committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    140152b View commit details
    Browse the repository at this point in the history

  8. Re-add changes lost on rebase

    @QPotato
    QPotato committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    2971adc View commit details
    Browse the repository at this point in the history

  9. Add documentation on public method

    @QPotato
    QPotato committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    214c222 View commit details
    Browse the repository at this point in the history

  10. Use triple slash on public method docs

    @QPotato
    QPotato committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    616e69b View commit details
    Browse the repository at this point in the history