-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split prefunded Channel
into Inbound
/Outbound
channels
#2077
Split prefunded Channel
into Inbound
/Outbound
channels
#2077
Commits on Jun 14, 2023
-
Move
Channel
fields intoChannelContext
structThis is a first step for simplifying the channel state and introducing new unfunded channel types that hold similar state before being promoted to funded channels. Essentially, we want the outer `Channel` type (and upcoming channel types) to wrap the context so we can apply typestate patterns to the that wrapper while also deduplicating code for common state and other internal fields.
Configuration menu - View commit details
-
Copy full SHA for 883afb3 - Browse repository at this point
Copy the full SHA 883afb3View commit details -
Move
Channel::opt_anchors
toChannelContext
impl & move some util…… fns This is one of a series of commits to make sure methods are moved by chunks so they are easily reviewable in diffs. Unfortunately they are not purely move-only as fields need to be updated for things to compile, but these should be quite clear.
Configuration menu - View commit details
-
Copy full SHA for 1503ebb - Browse repository at this point
Copy the full SHA 1503ebbView commit details -
Move
Channel::get_update_time_counter
and some other methodsThis is one of a series of commits to make sure methods are moved by chunks so they are easily reviewable in diffs. Unfortunately they are not purely move-only as fields need to be updated for things to compile, but these should be quite clear. This commit also uses these methods through the `context` field where needed for compilation and tests to pass due to the above change.
Configuration menu - View commit details
-
Copy full SHA for 1ee0a66 - Browse repository at this point
Copy the full SHA 1ee0a66View commit details -
Move
Channel::channel_id
and some other methods toChannelContext
…… impl This is one of a series of commits to make sure methods are moved by chunks so they are easily reviewable in diffs. Unfortunately they are not purely move-only as fields need to be updated for things to compile, but these should be quite clear. This commit also uses the `context` field where needed for compilation and tests to pass due to the above change.
Configuration menu - View commit details
-
Copy full SHA for ede8324 - Browse repository at this point
Copy the full SHA ede8324View commit details -
Move
Channel::build_commitment_transaction
toChannelContext
implThis is one of a series of commits to make sure methods are moved by chunks so they are easily reviewable in diffs. Unfortunately they are not purely move-only as fields need to be updated for things to compile, but these should be quite clear. This commit also uses the `context` field where needed for compilation and tests to pass due to the above change.
Configuration menu - View commit details
-
Copy full SHA for 497aeb0 - Browse repository at this point
Copy the full SHA 497aeb0View commit details -
Move
Channel::build_holder_transaction_keys
and some other methodsThis is one of a series of commits to make sure methods are moved by chunks so they are easily reviewable in diffs. Unfortunately they are not purely move-only as fields need to be updated for things to compile, but these should be quite clear. This commit also uses the `context` field where needed for compilation and tests to pass due to the above change.
Configuration menu - View commit details
-
Copy full SHA for 0d739ee - Browse repository at this point
Copy the full SHA 0d739eeView commit details -
Move
Channel::get_feerate_sat_per_1000_weight
and other methodsThis is one of a series of commits to make sure methods are moved by chunks so they are easily reviewable in diffs. Unfortunately they are not purely move-only as fields to be updated for things to compile, but these should be quite clear. This commit also uses the `context` field where needed for compilation and tests to pass due to the above change. f s/tarcontext.get_/target_/
Configuration menu - View commit details
-
Copy full SHA for 3ff94fa - Browse repository at this point
Copy the full SHA 3ff94faView commit details -
Prepare some methods for upcoming moves to
ChannelContext
To reduce interleaving in commits, we introduce a `context` variable in methods to be moved in upcoming commits so there is minimal change with the moves.
Configuration menu - View commit details
-
Copy full SHA for 2774aa2 - Browse repository at this point
Copy the full SHA 2774aa2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed6a5bb - Browse repository at this point
Copy the full SHA ed6a5bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08ee72b - Browse repository at this point
Copy the full SHA 08ee72bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f4e714 - Browse repository at this point
Copy the full SHA 9f4e714View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60706d6 - Browse repository at this point
Copy the full SHA 60706d6View commit details -
Convert
ChannelDetails::from_channel
to `ChannelDetails::from_chann……el_context` This rename and refactor is so that we can get channel details from a `ChannelContext` which is a common object to all channels.
Configuration menu - View commit details
-
Copy full SHA for 25c1ad8 - Browse repository at this point
Copy the full SHA 25c1ad8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3f0c55 - Browse repository at this point
Copy the full SHA e3f0c55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1012526 - Browse repository at this point
Copy the full SHA 1012526View commit details
Commits on Jun 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 883e056 - Browse repository at this point
Copy the full SHA 883e056View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6c2f04 - Browse repository at this point
Copy the full SHA e6c2f04View commit details -
Configuration menu - View commit details
-
Copy full SHA for baadeb7 - Browse repository at this point
Copy the full SHA baadeb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ea27e0 - Browse repository at this point
Copy the full SHA 2ea27e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ad67cf - Browse repository at this point
Copy the full SHA 4ad67cfView commit details -
Create and use methods for counting channels
This commit also adds two new maps to `PeerState` for keeping track of `OutboundV1Channel`s and `InboundV1Channel`s so that further commits are a bit easier to review.
Configuration menu - View commit details
-
Copy full SHA for 4b1e286 - Browse repository at this point
Copy the full SHA 4b1e286View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a0cd5c - Browse repository at this point
Copy the full SHA 4a0cd5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 637e03a - Browse repository at this point
Copy the full SHA 637e03aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f93e2d - Browse repository at this point
Copy the full SHA 8f93e2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d957f36 - Browse repository at this point
Copy the full SHA d957f36View commit details