Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] New ChannelId struct #2484

Closed
wants to merge 8 commits into from
Closed

[WIP] New ChannelId struct #2484

wants to merge 8 commits into from

Conversation

optout21
Copy link
Contributor

@optout21 optout21 commented Aug 9, 2023 •
edited
Loading

Fixes #2408 . Introduces a new ChannelId struct, enclosing the 32-byte data, and specific constructors, for normal funding-tx-based and for temporary channel IDs.

TODO:

  • Determine how it affects APIs, uses, backward-compatibility
  • Tests for ChannelId serialization/deserialization
  • New macro log_channel_id!()
  • Review hints

@optout21
Copy link
Contributor Author

optout21 commented Aug 9, 2023

Redone in #2485, with squashed commits, closing.

@optout21 optout21 closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abstraction of ChannelId type
1 participant
@optout21