Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle self payments #2573

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Handle self payments #2573

wants to merge 2 commits into from

Commits on Mar 11, 2024

  1. feat: allow self payment 

    This PR solves issue lightningdevkit#2462. If we asked to
pay an invoice that we generated ourselves. We
generate PaymentSent and PaymentClaimable event
and mark the payment as fulfilled in our set
of outbound payments.

This PR is important because we realized users
can easily screw up self payments when they implement
it themselves. See here: https://lists.linuxfoundation.org/pipermail/lightning-dev/2023-June/003983.html
    @vladimirfomene
    vladimirfomene committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    10bd39b View commit details
    Browse the repository at this point in the history

  2. test: add test for self payment

    @vladimirfomene
    vladimirfomene committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    2880c55 View commit details
    Browse the repository at this point in the history