Use correct input sequence for HTLC claims from counterparty commitments #2606
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2606 +/- ##
==========================================
+ Coverage 88.84% 88.91% +0.07%
==========================================
Files 113 113
Lines 84729 85938 +1209
Branches 84729 85938 +1209
==========================================
+ Hits 75275 76412 +1137
- Misses 7240 7282 +42
- Partials 2214 2244 +30
☔ View full report in Codecov by Sentry. |
HTLC outputs, like the `to_remote` output, in commitment transactions with anchor outputs also have an additional `1 CSV` constraint on the counterparty. When spending such outputs, their corresponding input needs to have their sequence set to 1. This was done for HTLC claims from holder commitments, but unfortunately not for counterparty commitments as we were lacking test coverage.
wpaulino
force-pushed
the
anchors-counterparty-htlc-claim-sequence
branch
from
d3bc90d
to
3c83783
Compare
| Sequence::ENABLE_RBF_NO_LOCKTIME | ||
| }, | ||
| _ => { | ||
| debug_assert!(false, "This should not be reachable by 'untractable' or 'malleable with external funding' packages"); |
There was a problem hiding this comment.
Note to reviewer: in this context “malleable with external funding package” scope second-stage HTLC-timeout and HTLC-preimage claiming offered / received outputs on holder commitment transaction.
| fn as_tx_input(&self, previous_output: BitcoinOutPoint) -> TxIn { | ||
| let sequence = match self { | ||
| PackageSolvingData::RevokedOutput(_) => Sequence::ENABLE_RBF_NO_LOCKTIME, | ||
| PackageSolvingData::RevokedHTLCOutput(_) => Sequence::ENABLE_RBF_NO_LOCKTIME, |
There was a problem hiding this comment.
I think we’re testing the “anchor channel”-enabled revoked counterparty commitment offered HTLC outputs case in test_anchors_aggregated_revoked_htlc_tx though I’m unsure we’re testing the claim with justice transaction on revoked counterparty commitment received HTLC ? All routed payments L2029 are in the same direction.
There was a problem hiding this comment.
I think it's covered now in #2610.
HTLC outputs, like the
to_remoteoutput, in commitment transactions with anchor outputs also have an additional1 CSVconstraint on the counterparty. When spending such outputs, their corresponding input needs to have their sequence set to 1. This was done for HTLC claims from holder commitments, but unfortunately not for counterparty commitments as we were lacking test coverage.