Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional tests for BOLT 12 Offers payment flow #2697

Merged
merged 19 commits into from
Jan 24, 2024
Merged

Functional tests for BOLT 12 Offers payment flow #2697

merged 19 commits into from
Jan 24, 2024

Commits on Jan 16, 2024

  1. Add peel_onion_message method to OnionMessenger 

    When testing OnionMessenger in functional tests, it would be useful to
examine the contents of an OnionMessage response. Expose the standalone
peel_onion_message on OnionMessenger to facilitate this.
    @jkczyz
    jkczyz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    ec8c6fb View commit details
    Browse the repository at this point in the history

  2. Fix import order in functional_test_utils.rs

    @jkczyz
    jkczyz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    911ed6d View commit details
    Browse the repository at this point in the history

  3. DRY up EntropySource implementation 

    The ChaCha20-based EntropySource implementation is duplicated within the
sign module. Refactor those into a RandomBytes implementation so that it
may be reused both there. Also useful as a standalone EntropySource
implementation for tests where an independent EntropySource is needed to
ensure that backwards-compatibility testing is not broken.
    @jkczyz
    jkczyz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    8deac89 View commit details
    Browse the repository at this point in the history

  4. Support OnionMessenger in functional_test_utils 

    OnionMessenger is needed to write functional tests for ChannelManager's
OffersMessageHandler implementation. Also adds a TestMessageRouter,
which simply wraps DefaultMessageRouter for now.
    @jkczyz
    jkczyz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    3b6d039 View commit details
    Browse the repository at this point in the history

  5. Have TestRouter wrap DefaultRouter 

    TestRouter checks route and scoring expectations before delegating to
the standalone find_route function. Refactor it to wrap DefaultRouter
and delegate to it instead. This allows TestRouter to implement
create_blinded_payment_paths by delegating to DefaultRouter.
    @jkczyz
    jkczyz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    b578363 View commit details
    Browse the repository at this point in the history

  6. Remove "no-std" feature checks 

    An upcoming rust-bitcoin release will remove the "no-std" feature.
Replace "no-std" in feature checks with "std", negating as needed. Using
a single feature flag makes the checks more consistent across modules.
    @jkczyz
    jkczyz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    30c0702 View commit details
    Browse the repository at this point in the history

  7. Remove redundant negations from feature check

    @jkczyz
    jkczyz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    a1c3004 View commit details
    Browse the repository at this point in the history

  8. Consolidate conditional imports

    @jkczyz
    jkczyz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    aba7748 View commit details
    Browse the repository at this point in the history

  9. Functional tests for BOLT 12 Offers payment flow 

    ChannelManager provides utilities to create offers and refunds along
with utilities to initiate and request payment for them, respectively.
It also manages the payment flow via implementing OffersMessageHandler.
Test that functionality, including the resulting event generation.
    @jkczyz
    jkczyz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    1059ac3 View commit details
    Browse the repository at this point in the history

  10. Functional tests for offers without blinded paths

    @jkczyz
    jkczyz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    6c67e3e View commit details
    Browse the repository at this point in the history

  11. Functional tests for offers with blinded paths

    @jkczyz
    jkczyz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    533c3cc View commit details
    Browse the repository at this point in the history

  12. Functional tests for failing without blinded paths

    @jkczyz
    jkczyz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    7573150 View commit details
    Browse the repository at this point in the history

  13. Offers functional tests for duplicated payment ids

    @jkczyz
    jkczyz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    0a7a90a View commit details
    Browse the repository at this point in the history

  14. Add Features::clear_route_blinding for testing

    @jkczyz
    jkczyz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    e40387f View commit details
    Browse the repository at this point in the history

  15. Functional tests for failing without payment paths

    @jkczyz
    jkczyz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    1c51aa1 View commit details
    Browse the repository at this point in the history

  16. Functional test for failing duplicate payments

    @jkczyz
    jkczyz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    aef46d8 View commit details
    Browse the repository at this point in the history

  17. Add ASCII art diagram explaining offers_tests

    @jkczyz
    jkczyz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    ffc24c3 View commit details
    Browse the repository at this point in the history

  18. Reorganize #[cfg(not(c_bindings))] imports

    @jkczyz
    jkczyz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    5aeb6c5 View commit details
    Browse the repository at this point in the history

  19. Fix bench build warning

    @jkczyz
    jkczyz committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    4532fb5 View commit details
    Browse the repository at this point in the history