Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure successful message propagation in case of disconnection mid-handshake #2725

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Ensure successful message propagation in case of disconnection mid-handshake #2725

merged 2 commits into from
Feb 5, 2024

Commits on Jan 31, 2024

  1. Do not remove Outbound Channel immediately when peer disconnects 

    - Do not remove channel immediately when peer_disconnect, instead
  removed it after some time if peer doesn't reconnect soon (handled in
previous commit).
- Do not mark per ok_to_remove if we have some OutboundV1Channels too.
- Rebroadcast SendOpenChannel for outboundV1Channel when peer
  reconnects.
- Update the relevant tests to account for the behavior change.
- Repurpose the test_disconnect_in_funding_batch to test that all
  channels in the batch close when one them closes.
    @shaavan
    shaavan committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    ddf75af View commit details
    Browse the repository at this point in the history

  2. Add tests to check the introduced behaviour 

    - The first test make sure that the OutboundV1Channel is not
immediately removed when peers disconnect, but is removed after N timer
ticks.
- The second test makes sure that the SendOpenChannel is rebroadcasted
for the OutboundV1Channel if peer reconnects within time.
    @shaavan
    shaavan committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    a6a6b48 View commit details
    Browse the repository at this point in the history