Doc and style followups from #2675 #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds required linebreaks to keep the docs to a reasonable width.
935a716 changed the parameter names to `RevocationKey` derivation to remove the naming which made clear one of the two parameters is a countersignatory key, which is restored here.
wpaulino
reviewed
Nov 27, 2023
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2748 +/- ##
==========================================
+ Coverage 88.53% 90.52% +1.99%
==========================================
Files 114 115 +1
Lines 89417 106889 +17472
Branches 89417 106889 +17472
==========================================
+ Hits 79165 96763 +17598
+ Misses 7872 7806 -66
+ Partials 2380 2320 -60 ☔ View full report in Codecov by Sentry. |
TheBlueMatt
force-pushed
the
2023-11-2675-followups
branch
from
1753c63
to
c84b3c4
Compare
935a716 added new wrappers for the various channel keys, including a payment_key. However, the `payment_key` has been unused in lightning since the introduction (and broad requiring) of the `static_remotekey` feature. Thus, we simply remove it (and an incredibly stale TODO) here.
This also adds required linebreaks to keep the docs to a reasonable width.
TheBlueMatt
force-pushed
the
2023-11-2675-followups
branch
from
c84b3c4
to
3b6d693
Compare
|
Squashed. |
wpaulino
approved these changes
Jan 9, 2024
|
Aside from some variable renames, this PR is entirely whitespace and doc changes, so there's no real need to wait on a second reviewer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just doc updates, but also dropped the
PaymentKeytype that's actually unused.