Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-ups to #2688 #2791

Merged
merged 7 commits into from
Jan 11, 2024
Merged

Follow-ups to #2688 #2791

merged 7 commits into from
Jan 11, 2024

Commits on Dec 13, 2023

  1. DRY Channel::fail_htlc handling on holding cell free.

    @valentinewallace
    valentinewallace committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    2917666 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Clean up code DRY'd in previous commit.

    @valentinewallace
    valentinewallace committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    d0d1634 View commit details
    Browse the repository at this point in the history

  2. Fix logger usage during batched htlc processing of malforms. 

    Introduced due to a rebase error.
    @valentinewallace
    valentinewallace committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    5c880a0 View commit details
    Browse the repository at this point in the history

  3. DRY malformed HTLC handling during htlc batch processing.

    @valentinewallace
    valentinewallace committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    04e70ba View commit details
    Browse the repository at this point in the history

  4. Normalize order of (sha256_of_onion, failure_code) in trait. 

    This helps avoid destructuring the tuple.
    @valentinewallace
    valentinewallace committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    95b3ef4 View commit details
    Browse the repository at this point in the history

  5. Remove outdated comment.

    @valentinewallace
    valentinewallace committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    c1fbb90 View commit details
    Browse the repository at this point in the history

  6. Rename parameter from err_packet to err_contents. 

    This name is more accurate since the method has been generalized to support
malformed HTLCs.
    @valentinewallace
    valentinewallace committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    3ec4d52 View commit details
    Browse the repository at this point in the history