Feature-gate time use also in ElectrumSyncClient
#2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous commit introduced the `time` feature to gate the use of `SystemTime` dependent APIs in `EsploraSyncClient`. It however omitted doing the same for the Electrum side of things. Here, we address this oversight.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2817 +/- ##
==========================================
- Coverage 88.46% 88.45% -0.02%
==========================================
Files 114 114
Lines 91946 91946
Branches 91946 91946
==========================================
- Hits 81341 81331 -10
- Misses 8101 8110 +9
- Partials 2504 2505 +1 ☔ View full report in Codecov by Sentry. |
TheBlueMatt
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, #2799 introduced the
timefeature to gate the use ofSystemTimedependent APIs inEsploraSyncClient.It however omitted doing the same for the Electrum side of things. Here, we address this oversight and make things symmetrical.