Test individual monitor update compl in chanmon_consistency fuzzer #2820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When users do async monitor updating, it may not be the case that all pending monitors will complete updating at once. Thus, we should fuzz monitor updates completing out of order, which we do here.
wpaulino
approved these changes
Jan 10, 2024
valentinewallace
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at #2819 I initially assumed we may have a bug (rather than just an undocumented requirement that leads to bugs) and added some fuzzing features to surface it. To my surprise, they didn't surface any new bugs (at least in the two CPU-weeks I was able to give the changes here today), but are worth upstreaming.
When users do async monitor updating, it may not be the case that all pending monitors will complete updating at once. Thus, we should fuzz monitor updates completing out of order, which we do here.