Drop PeerManager
type bound on UtxoLookup
entirely
#2822
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 6765967 we relaxed the bounds set on
UtxoLookup
to enable those usingRoutingMessageHandler
other thanP2PGossipSync
to useUtxoLookup
. Sadly, because this requires having a concretePeerManager
type which does not useUtxoLookup
in theRoutingMessageHandler
type, this broke users who were directly usingP2PGossipSync
.We could split
UtxoLookup
into two, with different bounds, for the two use-cases, but instead here we simply switch to storing a reference to thePeerManager
via adyn Fn
which allows us to wake thePeerManager
when we need to.Fixes #2813