Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce custom TLV support for OnionMessage #2830

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Introduce custom TLV support for OnionMessage #2830

wants to merge 4 commits into from

Commits on Nov 7, 2024

  1. Add Custom TLVs for message::ReceiveTlvs 

    - This update lets users add their own custom TLVs to the
  reply path of a sent onion message.
- By including these custom TLVs, users can send custom data
  with the message and get it back in the response.
    @shaavan
    shaavan committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    53996cc View commit details
    Browse the repository at this point in the history

  2. Distinguish Between Sender and User Custom TLVs 

    - This update introduces a clear separation between two types
  of custom TLVs: those sent by the sender for the user, and
  those added by the user to the reply path, which are expected
  to return with the response.
- This commit establishes this distinction in the codebase at
  relevant points.
- The next commit will build on this by providing an interface for
  users to add their own custom TLVs to the reply path, allowing
  them to receive specific data back in the response.

Note:
1. Similar to keysend, for serialization purposes, user_custom_tlv
   are assigned a specific TLV number.
2. For uniformity, user_custom_tlv are assigned the lowest possible
   odd number after (1 << 16), which is 65537.
    @shaavan
    shaavan committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    aa90229 View commit details
    Browse the repository at this point in the history

  3. Add Custom TLVs for payment::ReceiveTlvs 

    - Building on the previous commit, this update allows users to
  include their own custom TLVs within the reply path of a sent
  onion message.
- With this, users can attach custom data to the message, which
  will be returned in the response, providing more flexibility for
  custom use cases.
    @shaavan
    shaavan committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    0c33ae9 View commit details
    Browse the repository at this point in the history

  4. Test sending, and receiving of user_custom_tlvs

    @shaavan
    shaavan committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    f9a8608 View commit details
    Browse the repository at this point in the history