Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut 0.0.120 #2834

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Cut 0.0.120 #2834

merged 2 commits into from
Jan 17, 2024

Conversation

TheBlueMatt
Copy link
Collaborator

No description provided.

@TheBlueMatt TheBlueMatt added this to the 0.0.120 milestone Jan 17, 2024
Copy link

coderabbitai bot commented Jan 17, 2024

Warning

Rate Limit Exceeded

@TheBlueMatt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 27 minutes and 19 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 871db63 and 37017ec.

Walkthrough

This release, version 0.0.120, marks a significant enhancement to the software. It introduces API updates, crucial bug fixes, and security improvements. Notably, it removes a previous limitation on UtxoLookup by eliminating the PeerManager bound, broadens the functionality with the complete implementation of route blinding, and revises the lightning-transaction-sync crate along with the onion_message structure. The release also clarifies the Event::ChannelClosed by restructuring it and addresses several critical issues, including a denial-of-service risk.

Changes

File(s) Summary
.../PeerManager, Event::ChannelClosed Removed PeerManager bound from UtxoLookup. Updated Event::ChannelClosed and restructured some variants.
.../route_blinding Fully implemented route blinding feature.
lightning-transaction-sync crate, onion_message module Updated crate with unspecified changes. Changed module layout.
Various Fixed connection hangs, panics, privacy leaks, and a denial-of-service vulnerability.

🐇✨
To the devs who code and test,
With each release, we are impressed!
Bugs hop away, with each patch,
Making our digital burrow top-notch!
🥕🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between a175958 and a60df5a.
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Additional comments: 3
CHANGELOG.md (3)
  • 3-37: The summary provided in the diff for version 0.0.120 includes several API updates, bug fixes, and security enhancements. It mentions the removal of the PeerManager bound on UtxoLookup, implementation of the route blinding feature, changes in the lightning-transaction-sync crate, and updates to the Event::ChannelClosed. Additionally, it notes the restructuring of CandidateRouteHop variants into individual structs and updates to the Feature's Eq and Hash implementation.
  • 26-34: The security section mentions a fix for a denial-of-service vulnerability related to the UserConfig::manually_accept_inbound_channels option and the open_channel message. It's crucial to ensure that the fix is thoroughly tested to prevent potential exploitation.
  • 26-34: The security section details a fix for a denial-of-service vulnerability. It's important to verify that the fix does not introduce any regressions or new vulnerabilities.

CHANGELOG.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (871db63) 88.53% compared to head (37017ec) 88.51%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2834      +/-   ##
==========================================
- Coverage   88.53%   88.51%   -0.03%     
==========================================
  Files         115      115              
  Lines       92277    92277              
  Branches    92277    92277              
==========================================
- Hits        81701    81682      -19     
- Misses       8072     8088      +16     
- Partials     2504     2507       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 871db63 and fe915b6.
Files ignored due to path filters (9)
  • lightning-background-processor/Cargo.toml is excluded by: !**/*.toml
  • lightning-block-sync/Cargo.toml is excluded by: !**/*.toml
  • lightning-custom-message/Cargo.toml is excluded by: !**/*.toml
  • lightning-invoice/Cargo.toml is excluded by: !**/*.toml
  • lightning-net-tokio/Cargo.toml is excluded by: !**/*.toml
  • lightning-persister/Cargo.toml is excluded by: !**/*.toml
  • lightning-rapid-gossip-sync/Cargo.toml is excluded by: !**/*.toml
  • lightning-transaction-sync/Cargo.toml is excluded by: !**/*.toml
  • lightning/Cargo.toml is excluded by: !**/*.toml
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • CHANGELOG.md

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 871db63 and 0253ccf.
Files ignored due to path filters (9)
  • lightning-background-processor/Cargo.toml is excluded by: !**/*.toml
  • lightning-block-sync/Cargo.toml is excluded by: !**/*.toml
  • lightning-custom-message/Cargo.toml is excluded by: !**/*.toml
  • lightning-invoice/Cargo.toml is excluded by: !**/*.toml
  • lightning-net-tokio/Cargo.toml is excluded by: !**/*.toml
  • lightning-persister/Cargo.toml is excluded by: !**/*.toml
  • lightning-rapid-gossip-sync/Cargo.toml is excluded by: !**/*.toml
  • lightning-transaction-sync/Cargo.toml is excluded by: !**/*.toml
  • lightning/Cargo.toml is excluded by: !**/*.toml
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • CHANGELOG.md

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@TheBlueMatt TheBlueMatt merged commit 5592378 into lightningdevkit:main Jan 17, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants