Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support normal channel operation with async signing #2849

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support normal channel operation with async signing #2849

wants to merge 2 commits into from

Commits on Jan 27, 2024

  1. Support normal channel operation with async signing 

    This is a do-over of lightningdevkit#2653, wherein we support asynchronous signing for
'normal' channel operation. This involves allowing the following
`ChannelSigner` methods to return an `Err` result, indicating that the
requested value is not available:

- get_per_commitment_point
- release_commitment_secret
- sign_counterparty_commitment

When the value does become available, channel operation can be resumed by
invoking `signer_unblocked`.

Note that this adds the current and next per-commitment point to the state
that is persisted by the channel monitor.
    @waterson
    waterson committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    1bea55f View commit details
    Browse the repository at this point in the history

  2. Allow async sigs during channel setup 

    Creates and manages an explicit `HolderCommitment` type to deal with managing
the current and next commitment points.
    @waterson
    waterson committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    8db91d7 View commit details
    Browse the repository at this point in the history