-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional coverage to full_stack_target
#2850
Add additional coverage to full_stack_target
#2850
Conversation
Warning Rate Limit Exceeded@TheBlueMatt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 40 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2850 +/- ##
==========================================
+ Coverage 89.18% 90.02% +0.84%
==========================================
Files 115 115
Lines 93379 98265 +4886
Branches 93379 98265 +4886
==========================================
+ Hits 83276 88466 +5190
+ Misses 7575 7373 -202
+ Partials 2528 2426 -102 ☔ View full report in Codecov by Sentry. |
4944c83
to
440a3ea
Compare
Slightly reducing the amount of data we read to do things.
440a3ea
to
b703226
Compare
To potentially get more test coverage
The whole point of full_stack_target is to just expose our entire API to the fuzzer and see what happens. Sadly, we're really only exposing a small subset of our API. This improves that by exposing a handful of other assorted methods from ChannelManager and PeerManager.
This will make test_no_existing_test_breakage marginally easier to update.
b703226
to
7aa06d2
Compare
Fixed silent rebase conflict and added coverage of channel config updating. |
Diff is fuzz-only and mostly additive so not really worth getting a second review on it. |
Based on #2810, this adds coverage in the
full_stack_target
which would have caught #2842, both directly (using node announcement generation) and indirectly (with a new test case which tests gossip forwarding).