Improve error message for invalid response lengths

[arik-so]

Presently, HTTP response bodies of length 0 or exceeding 2 * 4_000_000 + 32_000 simply return a spurious out of range error.

This uses less confusing phrasing.

[coderabbitai]

Walkthrough

The recent update enhances the error handling within the HttpClient functionality by improving the clarity of error messages. When encountering an invalid content length, the error now explicitly includes the problematic response length, aiding in debugging and enhancing user feedback.

Changes

File Path	Change Summary
.../http.rs	Enhanced error messaging for out-of-range content length in HttpClient.

🐇💻
In the land of code and byte,
A rabbit hopped into the light.
"Let errors clear as day be shown,
To fix the seeds of bugs we've sown."
🌟🥕

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 51d9ee3 and d3ad5ac.

Files selected for processing (1)

• lightning-block-sync/src/http.rs (1 hunks)

Additional comments: 1

lightning-block-sync/src/http.rs (1)

• 291-291: The error message for invalid response length has been improved to include the actual length, enhancing clarity for debugging. This change aligns with the PR's objective to provide more specific error messages.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 51d9ee3 and bb9b389.

Files selected for processing (1)

• lightning-block-sync/src/http.rs (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• lightning-block-sync/src/http.rs

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (51d9ee3) 89.18% compared to head (bb9b389) 89.18%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2862      +/-   ##
==========================================
- Coverage   89.18%   89.18%   -0.01%     
==========================================
  Files         116      116              
  Lines       93098    93098              
  Branches    93098    93098              
==========================================
- Hits        83034    83028       -6     
- Misses       7538     7540       +2     
- Partials     2526     2530       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[TheBlueMatt]

Sure, just an error message change and is, indeed, a bit cleaner.