Reserve async signing related channel TLV types #2978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A LDK user deployed to production a WIP version of the async signing branch in which two new TLVs were added to channel. To prevent them from needing to perform a migration, we can just new types for TLVs that have yet to be included in a release. A note has been added to ensure types 45 and 47 are not used for another purpose.
TheBlueMatt
approved these changes
Mar 29, 2024
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2978 +/- ##
==========================================
- Coverage 89.35% 89.33% -0.02%
==========================================
Files 117 117
Lines 95513 95514 +1
Branches 95513 95514 +1
==========================================
- Hits 85347 85332 -15
- Misses 7931 7946 +15
- Partials 2235 2236 +1 ☔ View full report in Codecov by Sentry. |
tnull
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A LDK user deployed to production a WIP version of the async signing branch (#2849) in which two new TLVs were added to channel. To prevent them from needing to perform a migration, we can just new types for TLVs that have yet to be included in a release. A note has been added to ensure types 45 and 47 are not used for another purpose.