Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Offer::signing_pubkey to Offer::issuer_id #3218

Merged
merged 7 commits into from
Sep 17, 2024
Merged

Rename Offer::signing_pubkey to Offer::issuer_id #3218

merged 7 commits into from
Sep 17, 2024
+422 −324

Commits on Sep 16, 2024

  1. Rename Offer::signing_pubkey to Offer::issuer_signing_pubkey 

    The spec was recently changed to use offer_issuer_id instead of
offer_node_id. LDK always used signing_pubkey to avoid confusion with a
node_id. Rename it to issuer_signing_pubkey now as InvoiceRequest and
Bolt12Invoice will have similarly named methods in upcoming commits.
    @jkczyz
    jkczyz committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    df58f26 View commit details
    Browse the repository at this point in the history

  2. Re-write Offer::issuer_signing_pubkey documentation

    @jkczyz
    jkczyz committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    7351270 View commit details
    Browse the repository at this point in the history

  3. Add issuer_signing_pubkey to Bolt12Invoice 

    Useful for determining if the signing_pubkey is the
issuer_signing_pubkey or is from a blinded path.
    @jkczyz
    jkczyz committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    a466f2e View commit details
    Browse the repository at this point in the history

  4. Use unsigned invoice types in docs

    @jkczyz
    jkczyz committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    cfe8430 View commit details
    Browse the repository at this point in the history

  5. Update offer test vectors from latest spec changes

    @jkczyz
    jkczyz committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    de29295 View commit details
    Browse the repository at this point in the history

  6. Rename InvoiceRequest::payer_id 

    For consistency with Offer::issuer_signing_pubkey, rename
InvoiceRequest::payer_id to use "signing_pubkey" instead of "id".
    @jkczyz
    jkczyz committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    dd8f744 View commit details
    Browse the repository at this point in the history

  7. Rename Refund::payer_id 

    For consistency with Offer::issuer_signing_pubkey, rename
Refund::payer_id to use "signing_pubkey" instead of "id".
    @jkczyz
    jkczyz committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e11025f View commit details
    Browse the repository at this point in the history