Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Creation of Offers and Refunds Without Blinded Path #3246

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Enable Creation of Offers and Refunds Without Blinded Path #3246

wants to merge 6 commits into from

Commits on Oct 24, 2024

  1. Introduce BlindedPathType 

    1. Introduce a new enum that allows the user to specify the type
   of Blinded Path (whether Compact or Full-Length) when creating
   a Blinded Path.
2. This PR utilizes this new enum in two ways in the upcoming commits:
   - Allows explicitly providing the type of Blinded Path to be created
     instead of relying on the absolute expiry time for offers and refunds.
   - Simplifies the Blinded Path creation process by enabling a single
     function flow for creating both types of Blinded Path.
    @shaavan
    shaavan committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    b9645d8 View commit details
    Browse the repository at this point in the history

  2. Allow explicit specification of Blinded Path type in `create_offer_bu… 

    …ilder`

1. This commit introduces flexibility for the user to specify the
   type of Blinded Path they want, rather than relying on the Offers'
   absolute expiry to determine the Blinded Path type.
2. It also adds support for creating an Offer without a Blinded Path,
   using its signing public key for responding to the offer instead.
    @shaavan
    shaavan committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    fab8816 View commit details
    Browse the repository at this point in the history

  3. Allow Explicit Specification of Blinded Path Type in Refund 

    Similar to the offer case, this commit introduces the ability
to explicitly specify the Blinded Path type.
    @shaavan
    shaavan committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    e297444 View commit details
    Browse the repository at this point in the history

  4. Update DefaultMessageRouter's implmentation

    @shaavan
    shaavan committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    ffb13c3 View commit details
    Browse the repository at this point in the history

  5. Use all the paths returned by MessageRouter 

    - Instead of appending just a single blinded path to offers and refunds,
  update the code to append all paths returned by MessageRouter.
- This change allows MessageRouter to control the number of blinded paths
  appended to offers and refunds, providing flexibility for them to contain
  more than one path.
    @shaavan
    shaavan committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    44e9789 View commit details
    Browse the repository at this point in the history

  6. Introduce Tests for Offers and Refunds Without Blinded Paths

    @shaavan
    shaavan committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    863dcd6 View commit details
    Browse the repository at this point in the history