Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix builds of lightning-rapid-gossip-sync and lightning-background-processor crates #3289

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Fix builds of lightning-rapid-gossip-sync and lightning-background-processor crates #3289

merged 3 commits into from
Sep 18, 2024

Commits on Sep 18, 2024

  1. Re-add optional std feature dependencies to fix RGS and BP builds 

    We previously removed these, leading to failure to build under default
features including `std`.
    @tnull
    tnull committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3c1a5d3 View commit details
    Browse the repository at this point in the history

  2. Check workspace members with default features individually in CI 

    Previously, we would only check the workspace as a whole. This however
would mean that we would check/test crates with `lightning`'s default
features enabled, allowing failures-to-build under the crates own
default features to slip through, if they didn't explicitly enable
`lightning/std`, for example.

Here, we extend the CI to check the workspace as a whole but then run
checks, tests, and doc generation on the workspace members individually,
asserting that all of them build even when not built as part of the same
workspace as `lightning`.
    @tnull
    tnull committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a06e7b9 View commit details
    Browse the repository at this point in the history

  3. Drop no-std feature 

    We drop the `lightning/no-std` feature and just take
`hashbrown`,`possiblyrandom` and `libm` as required dependencies.
    @tnull
    tnull committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    545b037 View commit details
    Browse the repository at this point in the history