Finish closing channel after async closing signed #3296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3296 +/- ##
==========================================
- Coverage 89.85% 89.60% -0.25%
==========================================
Files 126 126
Lines 104145 102170 -1975
Branches 104145 102170 -1975
==========================================
- Hits 93577 91549 -2028
+ Misses 7894 7890 -4
- Partials 2674 2731 +57 ☔ View full report in Codecov by Sentry. |
In addressing a followup to test reconnection during closing negotation with async signing, we change things to only return a `ShutdownResult` when we actually finish shutting down the channel, i.e. we have the signature ready to send the final closing signed. This slightly simplifies the logic where we would shutdown our channel prematurely before we got the final signature. This also means that we don't push multiple `ChannelClosed` events if we receive closing signed, reconnect, and receive closing signed again.
alecchendev
force-pushed
the
2024-09-async-close-sign-followup
branch
from
7c77fcf
to
1fa7bf9
Compare
TheBlueMatt
approved these changes
Sep 9, 2024
valentinewallace
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing follow up in #3153 (comment).
In addressing a followup to test reconnection during closing negotation with async signing, we change things to only return a
ShutdownResultwhen we actually finish shutting down the channel, i.e. we have the signature ready to send the final closing signed. This slightly simplifies the logic where we would shutdown our channel prematurely before we got the final signature. This also means that we don't push multipleChannelClosedevents if we receive closing signed, reconnect, and receive closing signed again.