Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix silent rebase conflict that broke tests #3321

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

valentinewallace
Copy link
Contributor

429cbe1 merged a PR that renamed Offer::signing_pubkey to Offer::issuer_signing_pubkey. However, there was a silent rebase conflict and a test added as part of 1059f5f did not get the memo and used the old method name, breaking the test build.

429cbe1 merged a PR that renamed
Offer::signing_pubkey to Offer::issuer_signing_pubkey. However, there was a
silent rebase conflict and a test added as part of
1059f5f did not get the memo and used the old
method name, breaking the test build.
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.62%. Comparing base (429cbe1) to head (487d6a0).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3321      +/-   ##
==========================================
- Coverage   89.63%   89.62%   -0.01%     
==========================================
  Files         126      126              
  Lines      102564   102668     +104     
  Branches   102564   102668     +104     
==========================================
+ Hits        91937    92021      +84     
- Misses       7905     7920      +15     
- Partials     2722     2727       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheBlueMatt TheBlueMatt merged commit ca27a85 into lightningdevkit:main Sep 17, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants