Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce cfg(dual_funding) for handling of open_channel2 messages #3485

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dunxen
Copy link
Contributor

@dunxen dunxen commented Dec 13, 2024

There is still some work to be done here (like #3423) and it probably makes sense to release this (around v0.2) with the ability to open V2 channels too. This would also make our functional tests for dual-funding more complete.

@dunxen dunxen added this to the 0.1 milestone Dec 13, 2024
@dunxen dunxen marked this pull request as draft December 13, 2024 09:14
@dunxen dunxen force-pushed the 2024-12-cfgflagdualfunding branch from 490b2ac to d67c00a Compare December 13, 2024 09:23
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.77%. Comparing base (6e85a0d) to head (e5f6e4e).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channelmanager.rs 80.00% 3 Missing ⚠️
lightning/src/ln/peer_handler.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3485      +/-   ##
==========================================
+ Coverage   89.71%   89.77%   +0.06%     
==========================================
  Files         130      129       -1     
  Lines      107625   112231    +4606     
  Branches   107625   112231    +4606     
==========================================
+ Hits        96553   100760    +4207     
- Misses       8672     9166     +494     
+ Partials     2400     2305      -95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dunxen dunxen force-pushed the 2024-12-cfgflagdualfunding branch from d67c00a to e774784 Compare December 13, 2024 09:56
@dunxen dunxen marked this pull request as ready for review December 13, 2024 10:01
@dunxen dunxen force-pushed the 2024-12-cfgflagdualfunding branch from e774784 to e8cf37e Compare December 13, 2024 17:39
@jkczyz jkczyz self-requested a review December 13, 2024 17:45
We will not support accepting V2 channels in the v0.1 release, but
we do need to document the API change for push_msats -> channel_negotiation_type.
@dunxen dunxen force-pushed the 2024-12-cfgflagdualfunding branch from e8cf37e to e5f6e4e Compare December 14, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants