Reintroduce cfg(dual_funding) for handling of open_channel2 messages #3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunxen
force-pushed
the
2024-12-cfgflagdualfunding
branch
from
490b2ac to
d67c00a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3485 +/- ##
==========================================
+ Coverage 89.71% 89.77% +0.06%
==========================================
Files 130 129 -1
Lines 107625 112231 +4606
Branches 107625 112231 +4606
==========================================
+ Hits 96553 100760 +4207
- Misses 8672 9166 +494
+ Partials 2400 2305 -95 ☔ View full report in Codecov by Sentry. |
dunxen
force-pushed
the
2024-12-cfgflagdualfunding
branch
from
d67c00a to
e774784
Compare
dunxen
force-pushed
the
2024-12-cfgflagdualfunding
branch
from
e774784 to
e8cf37e
Compare
TheBlueMatt
reviewed
Dec 13, 2024
TheBlueMatt
reviewed
Dec 13, 2024
We will not support accepting V2 channels in the v0.1 release, but we do need to document the API change for push_msats -> channel_negotiation_type.
dunxen
force-pushed
the
2024-12-cfgflagdualfunding
branch
from
e8cf37e to
e5f6e4e
Compare
|
Note: previously splicing branches used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is still some work to be done here (like #3423) and it probably makes sense to release this (around v0.2) with the ability to open V2 channels too. This would also make our functional tests for dual-funding more complete.