Skip to content

[Docs] LSPS2: Improve invoice_parameters_generated docs #3871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martinsaposnic
Copy link
Contributor

Closes #3478

On invoice_parameters_generated, explicitly mention that the intercept SCID needs to be retrieved from ChannelManager::get_intercept_scid

This PR documents and matches exactly what ldk-node is doing here https://github.com/lightningdevkit/ldk-node/blob/main/src/liquidity.rs#L554-L586

On invoice_parameters_generated, explicitly mention that the
intercept SCID needs to be retrieved from ChannelManager::get_intercept_scid.
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jun 17, 2025

I've assigned @jkczyz as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-reviews-bot ldk-reviews-bot requested a review from jkczyz June 17, 2025 15:44
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.73%. Comparing base (b5bfa85) to head (5d2f8bc).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3871      +/-   ##
==========================================
- Coverage   89.75%   89.73%   -0.03%     
==========================================
  Files         164      164              
  Lines      132834   133079     +245     
  Branches   132834   133079     +245     
==========================================
+ Hits       119229   119413     +184     
- Misses      10926    10978      +52     
- Partials     2679     2688       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSPS2: Improve invoice_parameters_generated docs
2 participants