Skip to content

Rustfmt parts of channelmanager.rs #3960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2025

Conversation

joostjager
Copy link
Contributor

Prepare for #3957

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jul 25, 2025

I've assigned @tankyleo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Copy link

codecov bot commented Jul 25, 2025

Codecov Report

❌ Patch coverage is 79.41176% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.93%. Comparing base (55baa15) to head (0d56fb7).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channelmanager.rs 79.41% 27 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3960      +/-   ##
==========================================
- Coverage   88.94%   88.93%   -0.02%     
==========================================
  Files         173      173              
  Lines      123794   123876      +82     
  Branches   123794   123876      +82     
==========================================
+ Hits       110114   110165      +51     
- Misses      11227    11255      +28     
- Partials     2453     2456       +3     
Flag Coverage Δ
fuzzing 22.17% <0.00%> (-0.04%) ⬇️
tests 88.75% <79.41%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joostjager joostjager marked this pull request as ready for review July 25, 2025 13:29
@ldk-reviews-bot ldk-reviews-bot requested a review from tankyleo July 25, 2025 13:30
Copy link
Contributor

@tankyleo tankyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced both commits on my machine.

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@TheBlueMatt TheBlueMatt merged commit ed42300 into lightningdevkit:main Jul 25, 2025
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants