Add easy way to convert Bolt11InvoiceDescriptionRef to Bolt11InvoiceDescription
#4012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've assigned @joostjager as a reviewer! |
…escription Small annoyance I found when updating in one of my downstream projects. If you want to turn a Bolt11InvoiceDescriptionRef into a Bolt11InvoiceDescription you had to do it manually. This is useful if you're trying to create an invoice with the same description as another invoice.
benthecarman
force-pushed
the
desc-ref-to-desc
branch
from
5ce6539 to
56dd01b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4012 +/- ##
==========================================
- Coverage 88.85% 88.68% -0.18%
==========================================
Files 175 174 -1
Lines 127710 127598 -112
Branches 127710 127598 -112
==========================================
- Hits 113478 113158 -320
- Misses 11675 11965 +290
+ Partials 2557 2475 -82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small annoyance I found when updating in one of my downstream projects. If you want to turn a Bolt11InvoiceDescriptionRef into a Bolt11InvoiceDescription you had to do it manually. This is useful if you're trying to create an invoice with the same description as another invoice.