refactor(invoice): align signature checks with BOLT11 semantics #4064
Conversation
|
👋 Thanks for assigning @valentinewallace as a reviewer! |
erickcestari
force-pushed
the
improve-check-signature-bolt11
branch
from
9e89d85 to
c5c9121
Compare
erickcestari
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4064 +/- ##
==========================================
- Coverage 88.76% 88.33% -0.43%
==========================================
Files 176 177 +1
Lines 129518 131880 +2362
Branches 129518 131880 +2362
==========================================
+ Hits 114968 116502 +1534
- Misses 11945 12715 +770
- Partials 2605 2663 +58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
erickcestari
force-pushed
the
improve-check-signature-bolt11
branch
from
c5c9121 to
b91793a
Compare
|
🔔 1st Reminder Hey @valentinewallace! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @valentinewallace! This PR has been waiting for your review. |
|
🔔 3rd Reminder Hey @valentinewallace! This PR has been waiting for your review. |
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Simplify `check_signature` logic to follow the BOLT11 rules discussed: - If an `n` field is present, verify the signature against the included pubkey using `secp256k1_ecdsa_verify`, which enforces normalized low-S form. - If no `n` field is present, rely on `secp256k1_ecdsa_recover` to extract the pubkey. Recovery accepts both high-S and low-S signatures, matching existing implementations (lnd, c-lightning). This avoids redundant recovery+verify checks while preserving interoperability.
… high-S signature
erickcestari
force-pushed
the
improve-check-signature-bolt11
branch
from
25347f9 to
c678a9a
Compare
3 participants
Simplify
check_signaturelogic to follow the BOLT11 rules discussed:If an
nfield is present, verify the signature against the included pubkey usingsecp256k1_ecdsa_verify, which enforces normalized low-S form.If no
nfield is present, rely onsecp256k1_ecdsa_recoverto extract the pubkey. Recovery accepts both high-S and low-S signatures, matching existing implementations (lnd, c-lightning).This avoids redundant recovery+verify checks while preserving interoperability.
Context: lightning/bolts#1284