Simplify node reload logic in tests #4142
Draft
+60
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! I see this is a draft PR. |
joostjager
force-pushed
the
real-persist
branch
from
a5c6ff1 to
ccd72e0
Compare
joostjager
force-pushed
the
real-persist
branch
from
ccd72e0 to
5d9d8d0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4142 +/- ##
==========================================
- Coverage 88.63% 88.62% -0.02%
==========================================
Files 180 180
Lines 135230 135216 -14
Branches 135230 135216 -14
==========================================
- Hits 119865 119837 -28
- Misses 12594 12609 +15
+ Partials 2771 2770 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Store the latest persisted monitor in TestChainMonitor so it no longer needs to be passed into reload. This change also makes the test more realistic. If the monitor wasn't actually persisted, it won't reload properly.
joostjager
force-pushed
the
real-persist
branch
from
5d9d8d0 to
6688991
Compare
|
|
||
| let mut deserialized_fwd_htlcs = nodes[0].node.forward_htlcs.lock().unwrap(); | ||
| for scid in [scid_1, scid_2].iter() { | ||
| let mut deserialized_fwd_htlcs = nodes[0].node.forward_htlcs.lock().unwrap(); for scid in [scid_1, scid_2].iter() { |
There was a problem hiding this comment.
nit: needs newline
| } | ||
|
|
||
| #[cfg(test)] | ||
| macro_rules! reload_node_and_monitors { |
There was a problem hiding this comment.
Split into two macros? 😛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store the latest persisted monitor in TestChainMonitor so it no longer needs to be passed into reload. This change also makes the test more realistic. If the monitor wasn't actually persisted, it won't reload properly.
This is a preparation for the larger channel manager refactor project.