Skip to content

Custom channels liquidity edge case: AddInvoice with existing route hints #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: tapd-main-branch
Choose a base branch
from

Conversation

GeorgeTsagk
Copy link
Member

Description

Adds a new edge case to the custom channels test suite, where we call the taprpc.AddInvoice with existing route hints, which include a valid accepted quote.

Related tapd PR: lightninglabs/taproot-assets#1627

@GeorgeTsagk GeorgeTsagk self-assigned this Jun 30, 2025
@GeorgeTsagk GeorgeTsagk force-pushed the custom-chans-existing-routehints branch from 6221457 to 396bed5 Compare August 1, 2025 09:54
@GeorgeTsagk GeorgeTsagk changed the base branch from master to tapd-main-branch August 1, 2025 09:54
@GeorgeTsagk
Copy link
Member Author

This PR didn't get merged on time when the tapd counterpart got merged: lightninglabs/taproot-assets#1627

Rebased on tapd-main-branch and verified everything still works ✔️

@GeorgeTsagk GeorgeTsagk requested review from guggero and ffranr August 1, 2025 09:55
@GeorgeTsagk GeorgeTsagk force-pushed the custom-chans-existing-routehints branch from 396bed5 to 2fe7d87 Compare August 4, 2025 10:06
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 🎉

I've increased the linter timeout in the tapd-main-branch branch. If you rebase the failures should go away.

@GeorgeTsagk GeorgeTsagk force-pushed the custom-chans-existing-routehints branch from 2fe7d87 to c58b6d3 Compare August 4, 2025 12:23
@GeorgeTsagk
Copy link
Member Author

Rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants