Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

walletcollector: remove unused metric #63

Merged
merged 1 commit into from
Jan 15, 2021
Merged

walletcollector: remove unused metric #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions collectors/wallet_collector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ type WalletCollector struct {
confirmedBalanceDesc *prometheus.Desc
unconfirmedBalanceDesc *prometheus.Desc

// Per-transaction metrics.
txNumConfsDesc *prometheus.Desc

// errChan is a channel that we send any errors that we encounter into.
// This channel should be buffered so that it does not block sends.
errChan chan<- error
Expand All @@ -42,7 +39,6 @@ type WalletCollector struct {
func NewWalletCollector(lnd *lndclient.LndServices,
errChan chan<- error) *WalletCollector {

txLabels := []string{"tx_hash"}
return &WalletCollector{
lnd: lnd,
numUtxosConfDesc: prometheus.NewDesc(
Expand Down Expand Up @@ -75,9 +71,6 @@ func NewWalletCollector(lnd *lndclient.LndServices,
"unconfirmed wallet balance",
nil, nil,
),
txNumConfsDesc: prometheus.NewDesc(
"lnd_tx_num_confs", "number of confs", txLabels, nil,
),
errChan: errChan,
}
}
Expand All @@ -95,7 +88,6 @@ func (u *WalletCollector) Describe(ch chan<- *prometheus.Desc) {
ch <- u.avgUtxoSizeDesc
ch <- u.confirmedBalanceDesc
ch <- u.unconfirmedBalanceDesc
ch <- u.txNumConfsDesc
}

// Collect is called by the Prometheus registry when collecting metrics.
Expand Down Expand Up @@ -177,20 +169,4 @@ func (u *WalletCollector) Collect(ch chan<- prometheus.Metric) {
u.unconfirmedBalanceDesc, prometheus.GaugeValue,
float64(walletBal.Unconfirmed),
)

getTxsResp, err := u.lnd.Client.ListTransactions(
context.Background(), 0, 0,
)
if err != nil {
u.errChan <- fmt.Errorf("WalletCollector ListTransactions "+
"failed with: %v", err)
return
}

for _, tx := range getTxsResp {
ch <- prometheus.MustNewConstMetric(
u.txNumConfsDesc, prometheus.CounterValue,
float64(tx.Confirmations), tx.TxHash,
)
}
}